From b5033417919b399c962b162615215df4bab5c8c8 Mon Sep 17 00:00:00 2001 From: Michael Rose Date: Tue, 27 Feb 2018 13:34:58 -0500 Subject: [PATCH] Lint JavaScript --- .eslintrc.js | 24 ++++++++++++++++++++++++ CHANGELOG.md | 3 +++ assets/javascripts/main.js | 22 +++++++++++----------- 3 files changed, 38 insertions(+), 11 deletions(-) create mode 100644 .eslintrc.js diff --git a/.eslintrc.js b/.eslintrc.js new file mode 100644 index 0000000..628c49e --- /dev/null +++ b/.eslintrc.js @@ -0,0 +1,24 @@ +module.exports = { + "env": { + "browser": true + }, + "extends": "eslint:recommended", + "rules": { + "indent": [ + "error", + "tab" + ], + "linebreak-style": [ + "error", + "unix" + ], + "quotes": [ + "error", + "single" + ], + "semi": [ + "error", + "always" + ] + } +}; \ No newline at end of file diff --git a/CHANGELOG.md b/CHANGELOG.md index 8b12457..f8c0357 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/). ## Unreleased +## Changed +- Lint JavaScript. + ### Added - Accessibility enhancements for Lunr search form. diff --git a/assets/javascripts/main.js b/assets/javascripts/main.js index a4de63d..b638cf5 100644 --- a/assets/javascripts/main.js +++ b/assets/javascripts/main.js @@ -13,14 +13,14 @@ var menuItems = document.querySelectorAll('#sidebar li'); // Get vendor transition property var docElemStyle = document.documentElement.style; var transitionProp = typeof docElemStyle.transition == 'string' ? - 'transition' : 'WebkitTransition'; + 'transition' : 'WebkitTransition'; // Animate sidebar menu items function animateMenuItems() { - for ( var i=0; i < menuItems.length; i++ ) { + for (var i = 0; i < menuItems.length; i++) { var item = menuItems[i]; // Stagger transition with transitionDelay - item.style[ transitionProp + 'Delay' ] = ( i * 75 ) + 'ms'; + item.style[transitionProp + 'Delay'] = (i * 75) + 'ms'; item.classList.toggle('is--moved'); } }; @@ -35,7 +35,7 @@ var mySearchToggle = document.querySelector('.search-toggle'); // Toggle sidebar visibility function toggleClassMenu() { myMenu.classList.add('is--animatable'); - if(!myMenu.classList.contains('is--visible')) { + if (!myMenu.classList.contains('is--visible')) { myMenu.classList.add('is--visible'); myToggle.classList.add('open'); myWrapper.classList.add('is--pushed'); @@ -52,23 +52,23 @@ function OnTransitionEnd() { } myMenu.addEventListener('transitionend', OnTransitionEnd, false); -myToggle.addEventListener('click', function() { +myToggle.addEventListener('click', function () { toggleClassMenu(); animateMenuItems(); }, false); -myMenu.addEventListener('click', function() { +myMenu.addEventListener('click', function () { toggleClassMenu(); animateMenuItems(); }, false); -mySearchToggle.addEventListener('click', function() { +mySearchToggle.addEventListener('click', function () { toggleClassSearch(); }, false); // Toggle search input and content visibility function toggleClassSearch() { - mySearchContent.classList.toggle("is--visible"); - myInitialContent.classList.toggle("is--hidden"); - setTimeout(function() { - document.querySelector(".search-content input").focus(); + mySearchContent.classList.toggle('is--visible'); + myInitialContent.classList.toggle('is--hidden'); + setTimeout(function () { + document.querySelector('.search-content input').focus(); }, 400); }