From 89aebb82ecfdfc4643067ed99121c146b98e48a8 Mon Sep 17 00:00:00 2001 From: Michael Rose Date: Thu, 16 Mar 2017 15:13:21 -0400 Subject: [PATCH] Cleanup SCSS Lint warnings --- _sass/basically-basic/_buttons.scss | 2 +- _sass/basically-basic/_icons.scss | 2 +- _sass/basically-basic/_layout.scss | 2 +- _sass/basically-basic/_navicons.scss | 12 +++--- _sass/basically-basic/_navigation.scss | 2 +- _sass/basically-basic/_sidebar.scss | 11 ++--- .../basically-basic/_syntax-highlighting.scss | 42 +++++++++---------- _sass/basically-basic/themes/_default.scss | 2 +- _sass/basically-basic/themes/_steel.scss | 2 +- .../utilities/_accessibility.scss | 4 +- _sass/basically-basic/utilities/_align.scss | 2 +- 11 files changed, 38 insertions(+), 45 deletions(-) diff --git a/_sass/basically-basic/_buttons.scss b/_sass/basically-basic/_buttons.scss index 4ef4b33..9502d32 100644 --- a/_sass/basically-basic/_buttons.scss +++ b/_sass/basically-basic/_buttons.scss @@ -15,8 +15,8 @@ cursor: pointer; &:hover { - color: #fff; background-color: tint($accent-color, 20%); + color: #fff; } &:focus { diff --git a/_sass/basically-basic/_icons.scss b/_sass/basically-basic/_icons.scss index 260d668..7df5282 100644 --- a/_sass/basically-basic/_icons.scss +++ b/_sass/basically-basic/_icons.scss @@ -27,7 +27,7 @@ (linkedin, #0077b5), (pinterest, #bd081c), (rss, #ffa500), - (soundcloud, #ff3300), + (soundcloud, #f30), (stackoverflow, #fe7a16), (tumblr, #36465d), (twitter, #1da1f2), diff --git a/_sass/basically-basic/_layout.scss b/_sass/basically-basic/_layout.scss index fe023b7..74a885b 100644 --- a/_sass/basically-basic/_layout.scss +++ b/_sass/basically-basic/_layout.scss @@ -78,8 +78,8 @@ main { .entry-content { @include breakpoint($medium) { - flex: 1; -ms-flex: 1; + flex: 1; } } diff --git a/_sass/basically-basic/_navicons.scss b/_sass/basically-basic/_navicons.scss index 90915e5..7803a3d 100644 --- a/_sass/basically-basic/_navicons.scss +++ b/_sass/basically-basic/_navicons.scss @@ -28,15 +28,15 @@ .navicon::before, .navicon::after { - transition: $navicon-duration/2; + transition-duration: $navicon-duration / 2; } &:hover { - transition: $navicon-duration; + transition-duration: $navicon-duration; .navicon::before, .navicon::after { - transition: $navicon-duration / 2; + transition-duration: $navicon-duration / 2; } .navicon::before { top: (2.5 * $navicon-height); } @@ -48,7 +48,7 @@ position: relative; width: $navicon-width; height: $navicon-height; - transition: $navicon-duration; + transition-duration: $navicon-duration; border-radius: $navicon-width; background: $navicon-content-bg; @@ -58,7 +58,7 @@ position: absolute; width: $navicon-width; height: $navicon-height; - transition: $navicon-duration $navicon-duration / 2; + transition-duration: $navicon-duration $navicon-duration / 2; border-radius: $navicon-width; background: $navicon-content-bg; content: ''; @@ -76,7 +76,7 @@ .open .navicon::before, .open .navicon::after { - transition: $navicon-duration; + transition-duration: $navicon-duration; } /* Minus */ diff --git a/_sass/basically-basic/_navigation.scss b/_sass/basically-basic/_navigation.scss index dd58358..380c6c1 100644 --- a/_sass/basically-basic/_navigation.scss +++ b/_sass/basically-basic/_navigation.scss @@ -27,8 +27,8 @@ > li { -ms-flex: 1; flex: 1; - -ms-flex-pack: justify; justify-content: space-between; + -ms-flex-pack: justify; } li + li { diff --git a/_sass/basically-basic/_sidebar.scss b/_sass/basically-basic/_sidebar.scss index 490c731..3c3fff8 100644 --- a/_sass/basically-basic/_sidebar.scss +++ b/_sass/basically-basic/_sidebar.scss @@ -72,7 +72,7 @@ -ms-transform: translateX(0); transform: translateX(0); - &:after { + &::after { opacity: 1; pointer-events: auto; } @@ -112,9 +112,9 @@ } @include breakpoint($large) { + max-width: (1.5 * $sidebar-width); -ms-transform: translateX(-1.5 * $sidebar-width); transform: translateX(-1.5 * $sidebar-width); - max-width: (1.5 * $sidebar-width); } } @@ -145,15 +145,10 @@ } } - - li { - - } - .contact-list { + @include fluid-type($min-vw, $max-vw, 18px, 24px); margin-top: 0.5rem; padding-top: 0.5rem; - @include fluid-type($min-vw, $max-vw, 18px, 24px); li:not(:last-child) { margin-bottom: 0.5rem; diff --git a/_sass/basically-basic/_syntax-highlighting.scss b/_sass/basically-basic/_syntax-highlighting.scss index eebdff5..eb5d512 100644 --- a/_sass/basically-basic/_syntax-highlighting.scss +++ b/_sass/basically-basic/_syntax-highlighting.scss @@ -7,8 +7,8 @@ background-color: $code-background-color; pre { - margin: 0; width: 100%; + margin: 0; } table { @@ -89,7 +89,7 @@ .m { color: #2aa198; } /* Literal.Number */ .s { color: #2aa198; } /* Literal.String */ .na { color: #586e75; } /* Name.Attribute */ - .nb { color: #B58900; } /* Name.Builtin */ + .nb { color: #b58900; } /* Name.Builtin */ .nc { color: #22b3eb; } /* Name.Class */ .no { color: #cb4b16; } /* Name.Constant */ .nd { color: #22b3eb; } /* Name.Decorator */ @@ -105,23 +105,23 @@ .ow { color: #859900; } /* Operator.Word */ .w { color: #586e75; } /* Text.Whitespace */ .mf { color: #2aa198; } /* Literal.Number.Float */ - .mh { color: #2aa198 } /* Literal.Number.Hex */ - .mi { color: #2aa198 } /* Literal.Number.Integer */ - .mo { color: #2aa198 } /* Literal.Number.Oct */ - .sb { color: #93a1a1 } /* Literal.String.Backtick */ - .sc { color: #2aa198 } /* Literal.String.Char */ - .sd { color: #586e75 } /* Literal.String.Doc */ - .s2 { color: #2aa198 } /* Literal.String.Double */ - .se { color: #cb4b16 } /* Literal.String.Escape */ - .sh { color: #586e75 } /* Literal.String.Heredoc */ - .si { color: #2aa198 } /* Literal.String.Interpol */ - .sx { color: #2aa198 } /* Literal.String.Other */ - .sr { color: #dc322f } /* Literal.String.Regex */ - .s1 { color: #2aa198 } /* Literal.String.Single */ - .ss { color: #2aa198 } /* Literal.String.Symbol */ - .bp { color: #22b3eb } /* Name.Builtin.Pseudo */ - .vc { color: #22b3eb } /* Name.Variable.Class */ - .vg { color: #22b3eb } /* Name.Variable.Global */ - .vi { color: #22b3eb } /* Name.Variable.Instance */ - .il { color: #2aa198 } /* Literal.Number.Integer.Long */ + .mh { color: #2aa198; } /* Literal.Number.Hex */ + .mi { color: #2aa198; } /* Literal.Number.Integer */ + .mo { color: #2aa198; } /* Literal.Number.Oct */ + .sb { color: #93a1a1; } /* Literal.String.Backtick */ + .sc { color: #2aa198; } /* Literal.String.Char */ + .sd { color: #586e75; } /* Literal.String.Doc */ + .s2 { color: #2aa198; } /* Literal.String.Double */ + .se { color: #cb4b16; } /* Literal.String.Escape */ + .sh { color: #586e75; } /* Literal.String.Heredoc */ + .si { color: #2aa198; } /* Literal.String.Interpol */ + .sx { color: #2aa198; } /* Literal.String.Other */ + .sr { color: #dc322f; } /* Literal.String.Regex */ + .s1 { color: #2aa198; } /* Literal.String.Single */ + .ss { color: #2aa198; } /* Literal.String.Symbol */ + .bp { color: #22b3eb; } /* Name.Builtin.Pseudo */ + .vc { color: #22b3eb; } /* Name.Variable.Class */ + .vg { color: #22b3eb; } /* Name.Variable.Global */ + .vi { color: #22b3eb; } /* Name.Variable.Instance */ + .il { color: #2aa198; } /* Literal.Number.Integer.Long */ } diff --git a/_sass/basically-basic/themes/_default.scss b/_sass/basically-basic/themes/_default.scss index 4824b74..2f67753 100644 --- a/_sass/basically-basic/themes/_default.scss +++ b/_sass/basically-basic/themes/_default.scss @@ -2,4 +2,4 @@ Default theme skin ========================================================================== */ -// Intentionally left blank \ No newline at end of file +// Intentionally left blank diff --git a/_sass/basically-basic/themes/_steel.scss b/_sass/basically-basic/themes/_steel.scss index 4a6e0f2..b497a27 100644 --- a/_sass/basically-basic/themes/_steel.scss +++ b/_sass/basically-basic/themes/_steel.scss @@ -6,7 +6,7 @@ $base-color: #3a4750 !default; $text-color: #303841 !default; $accent-color: #d72323 !default; -$background-color: #eeeeee !default; +$background-color: #eee !default; $code-background-color: #fff !default; $border-color: rgba($text-color, 0.25) !default; $overlay-color: #fff !default; diff --git a/_sass/basically-basic/utilities/_accessibility.scss b/_sass/basically-basic/utilities/_accessibility.scss index 0fd14e9..f870ee2 100644 --- a/_sass/basically-basic/utilities/_accessibility.scss +++ b/_sass/basically-basic/utilities/_accessibility.scss @@ -44,9 +44,7 @@ } .screen-reader-text:focus, -.screen-reader-shortcut:focus, -.genesis-nav-menu .search input[type="submit"]:focus, -.widget_search input[type="submit"]:focus { +.screen-reader-shortcut:focus { width: auto; height: auto; clip: auto !important; diff --git a/_sass/basically-basic/utilities/_align.scss b/_sass/basically-basic/utilities/_align.scss index d3a8bef..9de08e6 100644 --- a/_sass/basically-basic/utilities/_align.scss +++ b/_sass/basically-basic/utilities/_align.scss @@ -43,8 +43,8 @@ a img.align-right { .align-left, a img.align-left { - margin-bottom: 1rem; margin-right: 1rem; + margin-bottom: 1rem; float: left; }