From ee659cb2a82754c4b7f85f5b2bf9e6b009756fda Mon Sep 17 00:00:00 2001 From: Saku Laesvuori Date: Sun, 17 Sep 2023 16:39:41 +0300 Subject: [PATCH] Tag comments about suboptimal implementations --- src/Server/API.hs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Server/API.hs b/src/Server/API.hs index 7f3af0f..11127e5 100644 --- a/src/Server/API.hs +++ b/src/Server/API.hs @@ -54,7 +54,7 @@ dbUserToUser :: Monad m => Entity DBUser -> User m dbUserToUser user = let id = entityToID user DBUser {..} = entityVal user Success (MemberData {..}) = fromJSON dBUserMemberData - -- Explodes if database doesn't contain needed data + -- XXX: Explodes if database doesn't contain needed data in User { id = pure id , email = pure dBUserEmail @@ -147,7 +147,7 @@ updateUser :: (MonadRandom m, MonadDB m, MonadEmail m, MonadError GQLError m) => UserID -> UpdateData -> m UserID updateUser user (UpdateData {..}) = do hash <- sequence $ hashPassword <$> password - -- assert stuff valid + -- TODO: assert stuff valid verificationSecretUpdate <- maybe (pure Nothing) (const $ Just . (DBUserEmailVerificationSecret =. ) . Just <$> genVerificationSecret) email user <- updateUserData user